Re: [PATCH v3 1/9] bugreport: add tool to generate debugging info

From: Emily Shaffer <emilyshaffer@google.com>
Date: Nov 19, 2019, 20:25 UTC
Message-ID: <20191119202542.GB36377@google.com>
In-Reply-To: <xmqqr2284is5.fsf@gitster-ct.c.googlers.com>

On Sat, Nov 16, 2019 at 12:11:38PM +0900, Junio C Hamano wrote:

Show 15 quoted lines

> Emily Shaffer <emilyshaffer@google.com> writes:
> 
> > Teach Git how to prompt the user for a good bug report: reproduction
> > steps, expected behavior, and actual behavior. Later, Git can learn how
> > to collect some diagnostic information from the repository.
> 
> It makes sense, but I do not think of any good reason why this
> should be implemented as a builtin.  I'd expect it would probably
> need to collect more info on the running environment than otherwise
> necessary for the regular Git operation, and perhaps you'd want to
> even link with libraries that are not needed for the regular Git
> operation to achieve that.
> 
> Can you make it a standalone binary instead to avoid bloat of the
> main "git" binary?

Sure. This would fix some other issues (needing to link against curl to get the curl version, which is exactly what you implied). I wasn't certain which circumstances a standalone binary was preferred, but I agree with your reasoning here for sure.

 - Emily