Re: [PATCH v3 1/9] bugreport: add tool to generate debugging info
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- Nov 20, 2019, 02:09 UTC
- Message-ID
- <20191120020933.GD36377@google.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1911200027460.15956@tvgsbejvaqbjf.bet>
On Wed, Nov 20, 2019 at 12:31:42AM +0100, Johannes Schindelin wrote:
Show 15 quoted lines
> Hi Emily, > > On Tue, 19 Nov 2019, Emily Shaffer wrote: > > > [...] some other issues (needing to link against curl to get the curl > > version, which is exactly what you implied) [...] > > I did suggest on IRC to teach `git-remote-https` an option where it prints > the cURL version (and build options) and exits. > > This would have the further advantage of making sure that the correct > information is included. If you have two separate binaries that both link > to cURL, they could still be linked statically, to different versions of > cURL (this could happen e.g. if you have a `git-remote-https` from a > different build in your path).
Yeah, it's a good point and an angle I hadn't thought of. Thanks.
> In short: I still think that it would make for a much better idea to query > the `git-remote-https` executable for the version information than to link > `bugreport` to libcurl.
Will do - the git-bugreport standalone will invoke the git-remote-https standalone to ask for version info.
- Emily