Re: [PATCH v3 2/9] bugreport: generate config whitelist based on docs

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 28, 2019, 13:27 UTC
Message-ID: <nycvar.QRO.7.76.6.1910281425360.46@tvgsbejvaqbjf.bet>
In-Reply-To: <20191025025129.250049-3-emilyshaffer@google.com>

Hi Emily,

On Thu, 24 Oct 2019, Emily Shaffer wrote:

Show 9 quoted lines

> diff --git a/bugreport-generate-config-whitelist.sh b/bugreport-generate-config-whitelist.sh
> new file mode 100755
> index 0000000000..ca6b232024
> --- /dev/null
> +++ b/bugreport-generate-config-whitelist.sh
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +
> +grep -RhPo ".*(?=:: \/\/ bugreport-include)" Documentation/config \

I am rather certain that `-P` is not supported by BSD grep (see https://man.openbsd.org/grep).

Why not something portable, e.g.

	find Documentation/config -type f -exec cat {} \; |
	sed -n 's/^\(.*\):: \/\/ bugreport-include$/\1/p' \

Ciao, Dscho

Show 5 quoted lines

> +  >git-bugreport-config-whitelist
> --
> 2.24.0.rc0.303.g954a862665-goog
>
>