Re: [PATCH v7 00/11] [GSoC] Implement Corrected Commit Date

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 1, 2021, 18:26 UTC
Message-ID: <xmqq7dnrmypw.fsf@gitster.c.googlers.com>
In-Reply-To: <3c48f860-e743-afbe-63e8-99804036a965@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 10 quoted lines

>>      +    When adding new layer to the split commit-graph file, and when merging
>>      +    some or all layers (replacing them in the latter case), the new layer
>>      +    will have GDAT chunk if and only if in the final result there would be
>>      +    no layer without GDAT chunk just below it.
>
> While that is a quality message, v6 has landed in 'next' and I've begun
> working off of that version. As Taylor attempted to say [1], this topic
> should be considered final and updates should be follow-ups on top.
>
> [1] https://lore.kernel.org/git/YBYLwpKdUfxCNwaz@nand.local/

Sounds sensible, modulo s/final/solid enough/ ;-)

I would imagine that the "quality message" has something of value to keep to help future developers, and if that is the case, a follow-up patch to add to the Documentation/technical/ would be appropriate.

Thanks all, for a quality series.