Re: [PATCH v2 07/10] commit-graph: implement corrected commit date

From: Derrick Stolee <stolee@gmail.com>
Date: Aug 14, 2020, 12:24 UTC
Message-ID: <2c7ee14e-1c80-9860-7bcc-633ac43910a6@gmail.com>
In-Reply-To: <20200814045957.GA1380@Abhishek-Arch>

On 8/14/2020 12:59 AM, Abhishek Kumar wrote:

Show 6 quoted lines

> I solved the issue by adding a new member to struct commit_graph
> `read_generation_data` to maintain the "global" state of the entire
> commit-graph chain instead.
> 
> The relevant changes are in validate_mixed_generation_chain(),
> read_commit_graph_one() and fill_commit_graph_info().

I think this is a good way to go. Adding that restriction about the tip commit-graph was short-sighted of me and was likely to break in the future.

I think your solution here to store extra state from the entire chain into each layer makes a lot of sense.

Thanks! -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.