Re: [PATCH v6 00/11] [GSoC] Implement Corrected Commit Date
- From
Abhishek Kumar <abhishekkumar8222@gmail.com>
- Date
- Jan 23, 2021, 12:07 UTC
- Message-ID
- <YAwRbsfdErIlTP6v@Abhishek-Arch>
- In-Reply-To
- <2437ba7c-f9d9-34bd-5e08-eff96cadcf91@gmail.com>
On Mon, Jan 18, 2021 at 04:04:14PM -0500, Derrick Stolee wrote:
Show 22 quoted lines
> On 1/16/2021 1:11 PM, Abhishek Kumar via GitGitGadget wrote: > > This patch series implements the corrected commit date offsets as generation > > number v2, along with other pre-requisites. > ... > > Changes in version 6: > > > > * Fixed typos in commit message for "commit-graph: implement corrected > > commit date". > > * Removed an unnecessary else-block in "commit-graph: implement corrected > > commit date". > > * Validate mixed generation chain correctly while writing in "commit-graph: > > use generation v2 only if the entire chain does". > > * Die if the GDAT chunk indicates data has overflown but there are is no > > generation data overflow chunk. > > I checked the range-diff and looked once more through the patch > series. This version is good to go by my standards. > > Reviewed-by: Derrick Stolee <dstolee@microsoft.com> > > Thanks, Abhishek! >
Thanks a lot for the review and continued guidance through out the patch series!
- Abhishek