Re: [PATCH] MyFirstContribution.txt: fix undeclared variable i in sample code

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2021, 06:41 UTC
Message-ID: <xmqq7ddbme7q.fsf@gitster.g>
In-Reply-To: <2b2386b9-045d-a0b8-6dbc-8a9d0c446bea@gmail.com>

Saksham Mittal <gotlouemail@gmail.com> writes:

>> It is declared, there is an "int i;" a few lines up.
>
> Oh, man, I never even saw that! The patch is completely unnecessary
> then. Sorry for that!

No need to say sorry; you'd want to be a bit more careful next time, that's all.

Also, our code does not introduce a new variable in the first part of "for (;;)" loop control, so even if the original lacked decl for "i", the posted patch is not how we write our code for this project.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.