Re: Removing -Wdeclaration-after-statement

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 8, 2021, 17:05 UTC
Message-ID: <xmqq35n32fjs.fsf@gitster.g>
In-Reply-To: <211208.86wnkfl1ni.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> Why would that be sad? The intent of -Wdeclaration-after-statement is to
> catch C90 compatibility issues. Maybe we don't want to enable everything
> C99-related in this area at once, but why shouldn't we be removing
> -Wdeclaration-after-statement once we have a hard C99 dependency?

We already heard from people that we do not want vla, and I agree that we do not want all C99. decl-after-stmt is something I definitely do not want in our code, in order to keep the code more readable by declaring the things that will be used in the scope upfront, with documentation if needed. It tends to encourage us to keep our blocks smaller.