git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] MyFirstContribution.txt: fix undeclared variable i in sample code

From
Johannes Altmanninger <aclopte@gmail.com>
Date
Nov 13, 2021, 13:05 UTC
Message-ID
<20211113130508.zziheannky6dcilj@gmail.com>
In-Reply-To
<20211113122833.174330-1-gotlouemail@gmail.com>
On Sat, Nov 13, 2021 at 05:58:35PM +0530, Saksham Mittal wrote:
Show 19 quoted lines
> In the sample code given to print the arguments given to ```git psuh```,
> the iterating variable i is not declared as integer. I have fixed it so
> the error is no longer there.
> 
> Signed-off-by: Saksham Mittal <gotlouemail@gmail.com>
> ---
>  Documentation/MyFirstContribution.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt
> index 015cf24631..434a833a0b 100644
> --- a/Documentation/MyFirstContribution.txt
> +++ b/Documentation/MyFirstContribution.txt
> @@ -297,7 +297,7 @@ existing `printf()` calls in place:
>  		  "Your args (there are %d):\n",
>  		  argc),
>  	       argc);
> -	for (i = 0; i < argc; i++)
> +	for (int i = 0; i < argc; i++)
It is declared, there is an "int i;" a few lines up.
Previous: Saksham MittalNext: Saksham Mittal
Message 2 of 22 in “MyFirstContribution.txt: fix undeclared variable i in sample code”
  1. MyFirstContribution.txt: fix undeclared variable i in sample codeSaksham Mittal, Nov 13, 2021
  2. Johannes AltmanningerNov 13, 2021
  3. Saksham MittalNov 13, 2021
  4. Junio C HamanoNov 14, 2021
  5. Is 'for (int i = [...]' bad for C STD compliance reasons? (was: [PATCH] MyFirstContribution.txt: fix undeclared variable i in sample code)Ævar Arnfjörð Bjarmason, Nov 14, 2021
  6. Junio C HamanoNov 14, 2021
  7. Ævar Arnfjörð BjarmasonNov 14, 2021
  8. Carlo ArenasNov 14, 2021
  9. brian m. carlsonNov 14, 2021
  10. Carlo ArenasNov 14, 2021
  11. revision: use C99 declaration of variable in for() loopJunio C Hamano, Nov 15, 2021
  12. Martin ÅgrenNov 15, 2021
  13. Junio C HamanoNov 16, 2021
  14. brian m. carlsonNov 15, 2021
  15. Phillip WoodNov 17, 2021
  16. Ævar Arnfjörð BjarmasonNov 17, 2021
  17. SZEDER GáborNov 17, 2021
  18. Junio C HamanoNov 18, 2021
  19. Phillip WoodDec 7, 2021
  20. Junio C HamanoDec 7, 2021
  21. Removing -Wdeclaration-after-statement (was: [PATCH] revision: use C99 declaration of variable in for() loop)Ævar Arnfjörð Bjarmason, Dec 8, 2021
  22. Junio C HamanoDec 8, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.