Re: [PATCH] revision: use C99 declaration of variable in for() loop

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 7, 2021, 20:37 UTC
Message-ID: <xmqq35n46tif.fsf@gitster.g>
In-Reply-To: <836296d0-6eee-7c6b-04d0-d93909948611@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> ... I guess that means we
> have not had any warning flags set (because no such flags exist?)  to
> protect against the accidental introduction of the construct that this
> patch is testing compiler support for.

I think we actually saw some instances of "for (type var = ..." slipped through the review process, only to later get caught by some other means.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.