Re: [PATCH] Makefile: build libgit-rs and libgit-sys serially

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 26, 2025, 16:46 UTC
Message-ID: <xmqq7byqkp3p.fsf@gitster.g>
In-Reply-To: <20250826160437.2539113-1-davvid@gmail.com>

David Aguilar <davvid@gmail.com> writes:

Show 13 quoted lines

> The "cargo build" invocations in contrib/ cannot be run in parallel.
>
> "make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock warnings
> and can trigger ld errors during the build.
>
> The build errors are caused by two inner "make" invocations getting
> triggered concurrently: once inside of libgit-sys and another inside of
> libgit-rs.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Don't we need a similar change to t/Makefile, or "cargo test" does fine while "cargo build" cannot be run in parallel?

Show 14 quoted lines

>
> diff --git a/Makefile b/Makefile
> index 29a53520fd..286d3ba3b2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3989,7 +3989,7 @@ libgit-sys libgit-rs:
>  		cargo build \
>  	)
>  ifdef INCLUDE_LIBGIT_RS
> -all:: libgit-sys libgit-rs
> +all:: libgit-sys .WAIT libgit-rs
>  endif
>  
>  LIBGIT_PUB_OBJS += contrib/libgit-sys/public_symbol_export.o