Re: [PATCH] Makefile: build libgit-rs and libgit-sys serially

From: Kyle Lippincott <spectral@google.com>
Date: Aug 26, 2025, 17:44 UTC
Message-ID: <CAO_smVjviMdpZyHFp4zJc62DJYAZxLAc5yw68C3U+c5wbwRziA@mail.gmail.com>
In-Reply-To: <20250826160437.2539113-1-davvid@gmail.com>

On Tue, Aug 26, 2025 at 9:04 AM David Aguilar <davvid@gmail.com> wrote:

Show 25 quoted lines

>
> The "cargo build" invocations in contrib/ cannot be run in parallel.
>
> "make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock warnings
> and can trigger ld errors during the build.
>
> The build errors are caused by two inner "make" invocations getting
> triggered concurrently: once inside of libgit-sys and another inside of
> libgit-rs.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 29a53520fd..286d3ba3b2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3989,7 +3989,7 @@ libgit-sys libgit-rs:
>                 cargo build \
>         )
>  ifdef INCLUDE_LIBGIT_RS
> -all:: libgit-sys libgit-rs
> +all:: libgit-sys .WAIT libgit-rs

I'm not familiar enough with make or with rust, but do we need to depend on both of these here? Wouldn't it be sufficient to say libgit-rs depends on libgit-sys, and only explicitly depend on libgit-rs in `all::`?

Show 6 quoted lines

>  endif
>
>  LIBGIT_PUB_OBJS += contrib/libgit-sys/public_symbol_export.o
> --
> 2.50.0.7.gec2f25360c
>