git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: build libgit-rs and libgit-sys serially

From
David Aguilar <davvid@gmail.com>
Date
Aug 26, 2025, 16:04 UTC
Message-ID
<20250826160437.2539113-1-davvid@gmail.com>
The "cargo build" invocations in contrib/ cannot be run in parallel.

"make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock warnings and can trigger ld errors during the build.

The build errors are caused by two inner "make" invocations getting triggered concurrently: once inside of libgit-sys and another inside of libgit-rs.

Signed-off-by: David Aguilar <davvid@gmail.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 29a53520fd..286d3ba3b2 100644
--- a/Makefile
+++ b/Makefile
@@ -3989,7 +3989,7 @@ libgit-sys libgit-rs:
 		cargo build \
 	)
 ifdef INCLUDE_LIBGIT_RS
-all:: libgit-sys libgit-rs
+all:: libgit-sys .WAIT libgit-rs
 endif
 
 LIBGIT_PUB_OBJS += contrib/libgit-sys/public_symbol_export.o
-- 
2.50.0.7.gec2f25360c
Next: Junio C Hamano
Message 1 of 9 in “Makefile: build libgit-rs and libgit-sys serially”
  1. Makefile: build libgit-rs and libgit-sys seriallyDavid Aguilar, Aug 26, 2025
  2. Junio C HamanoAug 26, 2025
  3. Makefile: build libgit-rs and libgit-sys seriallyDavid Aguilar, Aug 26, 2025
  4. Kyle LippincottAug 26, 2025
  5. Junio C HamanoAug 27, 2025
  6. Kyle LippincottAug 26, 2025
  7. rsbecker@nexbridge.comAug 26, 2025
  8. Kyle LippincottAug 26, 2025
  9. rsbecker@nexbridge.comAug 26, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.