From: Junio C Hamano Date: Tue, 03 Oct 2017 04:12:08 GMT Subject: Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun Message-ID: In-Reply-To: <20171003003407.GW19555@aiede.mtv.corp.google.com> Jonathan Nieder writes: > Ann T Ropea wrote: > >> Of the many ways to spell the three-letter word, the variant "Git" >> should be used when referring to a repository in a description; or, in >> general, when it is used as a proper noun. >> >> We thus change the pull-request template message so that it reads >> >> "...in the Git repository at:" >> >> Besides, this brings us in line with the documentation, see >> Documentation/howto/using-signed-tag-in-pull-request.txt >> >> Signed-off-by: Ann T Ropea >> Acked-by: Jonathan Nieder >> --- >> v2: rename patch, correct Signed-off-by line, add Acked-by line >> git-request-pull.sh | 2 +- >> t/t5150-request-pull.sh | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) > > Reviewed-by: Jonathan Nieder > > Thanks for the quick turnaround. Thanks, but the patch is whitespace damaged and did not apply (what happend to "reviewer's oversight statement" ;-). As there were only three instances, I just edited the target files and committed, which was far quicker than trying to match whitespaces by editing the patch text.