Re: [PATCH 5/5] commit: support the --pathspec-from-file option

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 11, 2019, 16:14 UTC
Message-ID: <xmqq5zimrg9i.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <9d77a425-da8d-d6e7-f51f-c4ce6ee988d5@syntevo.com>

Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> writes:

> and I can continue to extend it in the same direction, or try to
> refactor to make it better. I actually choose the second path:
> [1][2]. These were two "don't" lessons for me, as both topics now
> gather dust in mail graveyard.

If nobody commented on your patches, that is not a punishment. It could have been that reviewers were busy addressing other issues back then, in which case a gentle ping by resending a polished version (it could be that the changes were not presented well to attract reviewers' attention---polishing the proposed log messages without changing the patch text might be all it takes to make them realize that the topic is worth looking at) would help.

> [1]
> https://public-inbox.org/git/pull.479.git.1574969538.gitgitgadget@gmail.com/
> [2]
> https://public-inbox.org/git/pull.477.git.1574848137.gitgitgadget@gmail.com/T/#u

I actually was meaning to read and comment on [1], but lack of time pushed it down in my queue. Sorry about that.