Re: [PATCH 3/5] reset: support the --pathspec-from-file option

I think I have implemented most suggestions in PatchV2. Thanks!

On 05.11.2019 16:03, Phillip Wood wrote:

> I'm confused reset does not use stdin does it?

I have improved commit message to clarify.

> --pathspec-file would be shorter and still conveys the intent of the 
> option.

I decided to stay with writing suggested by Junio.

> Is this line missing a leading space?

I think it's good. Maybe you were confused by patch formatting?

> Alignment again

I think it's good again :)

> If I've understood correctly this doesn't test if a path is correctly 
> unquoted, only that it is accepted.

Already agreed that test is good, just a bit non-obvious.

> s/^/--pathspec-from-file / ?

I decided not to repeat '--pathspec-from-file' in every test, because test package already has it in description. Is that good?