git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/5] Add --pathspec-from-file option for reset, commit

From
AGAlexandr Miloslavskiy via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 4, 2019, 19:26 UTC
Message-ID
<pull.445.git.1572895605.gitgitgadget@gmail.com>

Adds --pathspec-from-file option for porcelain commands to avoid commandline length limit.

So far I implemented it for git commit and git reset, but my goal is to support other commands as well after these patches are reviewed.

The patches are based on the following discussions: https://public-inbox.org/git/c3be6eff-365b-96b8-16d2-0528612fc1fc@syntevo.com/T/#u There, --stdin-paths was suggested. https://public-inbox.org/git/a38bc928-7ccd-e2d9-b89b-23298e9fa95d@syntevo.com/T/#u There, --stdin-paths was extended to --paths-file. https://public-inbox.org/git/pull.133.git.gitgitgadget@gmail.com/ https://github.com/gitgitgadget/git/pull/133Patch from Johannes, I used it as base of my patch. There, --pathspec-from-file is suggested in discussion.

Major changes compared to patch from Johannes:
1) --pathspec-from-file allows to read file, not just stdin 2) 
--literal-pathspecs should be honored. This is a good improvement because it
keeps --pathspec-from-file much closer to passing args on commandline. Since
the goal of the new option is to avoid commandline length limit, both
behaviors should be close to each other. 3) Patches are designed with all
other git commands in mind
Alexandr Miloslavskiy (5):
  pathspec: add new function to parse file
  doc: reset: unify <pathspec> description
  reset: support the --pathspec-from-file option
  doc: commit: unify <pathspec> description
  commit: support the --pathspec-from-file option
 Documentation/git-commit.txt    |  19 ++++-
 Documentation/git-reset.txt     |  40 +++++++---
 builtin/commit.c                |  25 ++++++-
 builtin/reset.c                 |  22 +++++-
 pathspec.c                      |  41 +++++++++++
 pathspec.h                      |  10 +++
 t/t7107-reset-pathspec-file.sh  | 126 ++++++++++++++++++++++++++++++++
 t/t7526-commit-pathspec-file.sh | 107 +++++++++++++++++++++++++++
 8 files changed, 371 insertions(+), 19 deletions(-)
 create mode 100755 t/t7107-reset-pathspec-file.sh
 create mode 100755 t/t7526-commit-pathspec-file.sh
base-commit: da72936f544fec5a335e66432610e4cef4430991
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-445%2FSyntevoAlex%2F%230207_pathspec_from_file-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-445/SyntevoAlex/#0207_pathspec_from_file-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/445
-- 
gitgitgadget
Next: Alexandr Miloslavskiy via GitGitGadget
Message 1 of 80 in “Add --pathspec-from-file option for reset, commit”
  1. 0/5 Add --pathspec-from-file option for reset, commitAlexandr Miloslavskiy via GitGitGadget, Nov 4, 2019
  2. 1/5 pathspec: add new function to parse fileAlexandr Miloslavskiy via GitGitGadget, Nov 4, 2019
  3. Phillip WoodNov 5, 2019
  4. Alexandr MiloslavskiyNov 5, 2019
  5. Alexandr MiloslavskiyNov 6, 2019
  6. 3/5 reset: support the --pathspec-from-file optionAlexandr Miloslavskiy via GitGitGadget, Nov 4, 2019
  7. Phillip WoodNov 5, 2019
  8. Phillip WoodNov 5, 2019
  9. Alexandr MiloslavskiyNov 5, 2019
  10. Alexandr MiloslavskiyNov 6, 2019
  11. Phillip WoodNov 5, 2019
  12. Alexandr MiloslavskiyNov 5, 2019
  13. Junio C HamanoNov 6, 2019
  14. Alexandr MiloslavskiyNov 6, 2019
  15. 4/5 doc: commit: unify <pathspec> descriptionAlexandr Miloslavskiy via GitGitGadget, Nov 4, 2019
  16. Junio C HamanoNov 6, 2019
  17. Alexandr MiloslavskiyNov 6, 2019
  18. Junio C HamanoNov 7, 2019
  19. Alexandr MiloslavskiyNov 7, 2019
  20. 5/5 commit: support the --pathspec-from-file optionAlexandr Miloslavskiy via GitGitGadget, Nov 4, 2019
  21. Phillip WoodNov 5, 2019
  22. Alexandr MiloslavskiyNov 5, 2019
  23. Alexandr MiloslavskiyNov 6, 2019
  24. Phillip WoodDec 10, 2019
  25. Alexandr MiloslavskiyDec 11, 2019
  26. Phillip WoodDec 11, 2019
  27. Alexandr MiloslavskiyDec 11, 2019
  28. Junio C HamanoDec 11, 2019
  29. Alexandr MiloslavskiyDec 11, 2019
  30. Alexandr MiloslavskiyDec 12, 2019
  31. Junio C HamanoNov 6, 2019
  32. 2/5 doc: reset: unify <pathspec> descriptionAlexandr Miloslavskiy via GitGitGadget, Nov 4, 2019
  33. Junio C HamanoNov 6, 2019
  34. Alexandr MiloslavskiyNov 6, 2019
  35. Junio C HamanoNov 7, 2019
  36. Alexandr MiloslavskiyNov 7, 2019
  37. Junio C HamanoNov 8, 2019
  38. 0/6 Add --pathspec-from-file option for reset, commitAlexandr Miloslavskiy via GitGitGadget, Nov 6, 2019
  39. 1/6 parse-options.h: add new options `--pathspec-from-file`, `--pathspec-file-nul`Alexandr Miloslavskiy via GitGitGadget, Nov 6, 2019
  40. 2/6 pathspec: add new function to parse fileAlexandr Miloslavskiy via GitGitGadget, Nov 6, 2019
  41. Junio C HamanoNov 19, 2019
  42. Alexandr MiloslavskiyNov 19, 2019
  43. 3/6 doc: reset: unify <pathspec> descriptionAlexandr Miloslavskiy via GitGitGadget, Nov 6, 2019
  44. Junio C HamanoNov 19, 2019
  45. Alexandr MiloslavskiyNov 19, 2019
  46. 6/6 commit: support the --pathspec-from-file optionAlexandr Miloslavskiy via GitGitGadget, Nov 6, 2019
  47. Junio C HamanoNov 19, 2019
  48. Alexandr MiloslavskiyNov 19, 2019
  49. 5/6 doc: commit: unify <pathspec> descriptionAlexandr Miloslavskiy via GitGitGadget, Nov 6, 2019
  50. Junio C HamanoNov 19, 2019
  51. Alexandr MiloslavskiyNov 19, 2019
  52. Alexandr MiloslavskiyNov 19, 2019
  53. 4/6 reset: support the `--pathspec-from-file` optionAlexandr Miloslavskiy via GitGitGadget, Nov 6, 2019
  54. 0/6 Add --pathspec-from-file option for reset, commitAlexandr Miloslavskiy via GitGitGadget, Nov 19, 2019
  55. 3/6 doc: reset: synchronize <pathspec> descriptionAlexandr Miloslavskiy via GitGitGadget, Nov 19, 2019
  56. 2/6 pathspec: add new function to parse fileAlexandr Miloslavskiy via GitGitGadget, Nov 19, 2019
  57. 5/6 doc: commit: synchronize <pathspec> descriptionAlexandr Miloslavskiy via GitGitGadget, Nov 19, 2019
  58. 4/6 reset: support the `--pathspec-from-file` optionAlexandr Miloslavskiy via GitGitGadget, Nov 19, 2019
  59. 1/6 parse-options.h: add new options `--pathspec-from-file`, `--pathspec-file-nul`Alexandr Miloslavskiy via GitGitGadget, Nov 19, 2019
  60. 6/6 commit: support the --pathspec-from-file optionAlexandr Miloslavskiy via GitGitGadget, Nov 19, 2019
  61. Junio C HamanoNov 20, 2019
  62. Alexandr MiloslavskiyNov 20, 2019
  63. 00/13 Add --pathspec-from-file optionAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  64. 01/13 parse-options.h: add new options `--pathspec-from-file`, `--pathspec-file-nul`Alexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  65. 03/13 doc: reset: synchronize <pathspec> descriptionAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  66. 02/13 pathspec: add new function to parse fileAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  67. 05/13 doc: commit: synchronize <pathspec> descriptionAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  68. 06/13 commit: support the --pathspec-from-file optionAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  69. 10/13 doc: checkout: fix broken text referenceAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  70. 07/13 cmd_add: prepare for next patchAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  71. 09/13 doc: checkout: remove duplicate synopsisAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  72. 04/13 reset: support the `--pathspec-from-file` optionAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  73. 08/13 add: support the --pathspec-from-file optionAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  74. 13/13 checkout, restore: support the --pathspec-from-file optionAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  75. 11/13 doc: checkout: synchronize <pathspec> descriptionAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  76. 12/13 doc: restore: synchronize <pathspec> descriptionAlexandr Miloslavskiy via GitGitGadget, Dec 3, 2019
  77. Junio C HamanoDec 3, 2019
  78. Alexandr MiloslavskiyDec 3, 2019
  79. Junio C HamanoDec 4, 2019
  80. Alexandr MiloslavskiyDec 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.