Re: [PATCH v2 6/6] commit: support the --pathspec-from-file option

From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Date: Nov 19, 2019, 16:56 UTC
Message-ID: <74889f88-b5dd-b1bd-f619-9201ce14db29@syntevo.com>
In-Reply-To: <xmqqo8x8xup8.fsf@gitster-ct.c.googlers.com>

On 19.11.2019 7:10, Junio C Hamano wrote:

Show 16 quoted lines

>> +--pathspec-file-nul::
>> +	Only meaningful with `--pathspec-from-file`. Pathspec elements are
>> +	separated with NUL character and are not expected to be quoted.
> 
> Although it is not incorrect, "are not expected to be quoted" feels
> a bit weak as the technical description.  Are they not expected to
> be quoted, but the command gracefully works on them even when they
> are found to be quoted?
> 
> Rephrasing to avoid such misinterpretation may be worth doing,
> perhaps
> 
> 	... and are taken as-is without unquoting (i.e. as if
> 	`core.quotePath` is set to `false`).
> 
> or something like that?

I think that a reference to `core.quotePath` could be confusing here, because it doesn't really affect the option. I have reworded it in V3, please see if you like it.

Thanks for pointing out!