Re: [PATCH v2 1/3] test-lib: allow selecting tests by substring/regex with --run
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 15, 2020, 16:10 UTC
- Message-ID
- <xmqq5z7bii6r.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CABPp-BGBG=wh41BrvFZdzsN6biUPvuDkrA9EZURM4GKLx8kC0A@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 14 quoted lines
> On Wed, Oct 14, 2020 at 10:57 AM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> > are you suggesting dropping the regex handling and limit it to
>> > substring matching? In either case, does using expr save us anything
>> > (isn't expr a shell command)?
>>
>> I had something along this line in mind, not to do a regex but a glob.
>>
>> case "$title" in $selector) found=1 ;; esac
>
> Interesting. Since it needs to handle substring searching (e.g.
> ./test-script.sh --run=setup,rename), I think this would need to be
> tweaked to be
> case "$title" in *${selector}*) include=$positive ;; esacYup, of course we need to un-anchor with surrounding asterisks. Thanks.