Re: [PATCH v4 0/3] Make test selection easier by specifying description substrings instead of just numeric counters
- From
Elijah Newren <newren@gmail.com>
- Date
- Oct 16, 2020, 20:56 UTC
- Message-ID
- <CABPp-BERdr-UvMEe=kjeRjtXfeV0uu2LOk6G3oYGMWe=gxKxeg@mail.gmail.com>
- In-Reply-To
- <xmqqzh4lapfr.fsf@gitster.c.googlers.com>
On Fri, Oct 16, 2020 at 1:25 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> > "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > Changes since v3: > > > > * Added text to the README explaining what to do if the substring you want > > to search on includes a comma or whitespace (namely, use the '?' glob > > character instead) > > That would work just as well with or without forbidding spaces. > > > ++The argument to --run is split on commas and whitespace into separate > > ++strings, numbers, and ranges, and picks all tests that match any of > > ++the individual selection criteria. If the substring of the > > ++description text that you want to match includes a comma or space, use > > ++the glob character '?' instead. For example --run='unnecessary?update > > ++timing' would match on all tests that match either the glob > > ++*unnecessary?update* or the glob *timing*. > > OK. > > Will queue.
Since both you and Peff argued for just changing IFS, I'll do that, and update this text and elsewhere in t/README to reflect that we only split on commas and send that in as v4.