Re: [PATCH 1/3] test-lib: allow selecting tests by substring/regex with --run

From: Elijah Newren <newren@gmail.com>
Date: Oct 13, 2020, 18:21 UTC
Message-ID: <CABPp-BHN6s6W03uH3WssUk0ukzgkBSiVXg3_K5m_XKNGtCSxiQ@mail.gmail.com>
In-Reply-To: <20201013172835.GA1917721@nand.local>

On Tue, Oct 13, 2020 at 10:28 AM Taylor Blau <me@ttaylorr.com> wrote:

Show 16 quoted lines

>
> On Tue, Oct 13, 2020 at 10:23:32AM -0700, Elijah Newren wrote:
> > On Tue, Oct 13, 2020 at 8:39 AM Taylor Blau <me@ttaylorr.com> wrote:
> > > This piece of documentation looks to be now out of date; it mentions a
> > > "test or range of tests", but that only covers a two of the now four
> > > ways to describe a test.
> >
> > Personally, I had read "test or range of tests" as general enough to
> > cover all the cases (I would have agreed that "test *number* or range
> > of tests" would sound out of date), and just left it.  However, if
> > there's something clearer, I'm happy to adopt it.  Do you have an
> > alternate wording suggestion?
>
> Maybe "test selectors"? You could even say something like "test
> selectors (e.g., the test number, a range, a substring/regular
> expression)". I don't know, though; I don't feel strongly about it.

Earlier in the document, the --run option is defined as
   --run=<test-selector>::
which might suggest to some readers that "test-selector" is the
combination of all the selections and thus that you can only negate
the whole series rather than individual components of it.

Perhaps we can just nuke this sentence with a slight tweak of the paragraph before it to include slightly more about the "optional negation prefix". I'll send an updated series that does that.