Re: [PATCH v5 1/3] test-lib: allow selecting tests by substring/glob with --run

From: Andrei Rybak <rybak.a.v@gmail.com>
Date: Oct 16, 2020, 23:25 UTC
Message-ID: <89279674-a1b5-930a-e682-b47aafeb11b7@gmail.com>
In-Reply-To: <389c2c171a07b156fe956ac535033a8b67af51a9.1602888652.git.gitgitgadget@gmail.com>

On 2020-10-17 00:50, Elijah Newren via GitGitGadget wrote:

[trim]

Show 16 quoted lines

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index ef31f40037..debfd73fd6 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -769,6 +769,8 @@ match_pattern_list () {
>  }
>  
>  match_test_selector_list () {
> +	operation="$1"
> +	shift
>  	title="$1"
>  	shift
>  	arg="$1"
> @@ -777,7 +779,7 @@ match_test_selector_list () {
>  
>  	# Both commas and whitespace are accepted as separators.

This comment becomes outdated with the change below.

Show 7 quoted lines

>  	OLDIFS=$IFS
> -	IFS=' 	,'
> +	IFS=','
>  	set -- $1
>  	IFS=$OLDIFS
>  
> @@ -805,13 +807,13 @@ match_test_selector_list () {