git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/3] Take four on fixing OPT_SET_PTR issues

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 31, 2014, 17:23 UTC
Message-ID
<xmqq4n2e8eov.fsf@gitster.dls.corp.google.com>
In-Reply-To
<cover.1396177207.git.marat@slonopotamus.org>
Marat Radchenko <marat@slonopotamus.org> writes:
Show 11 quoted lines
> Patches summary:
> 1. Fix initial issue (incorrect cast causing crash on 64-bit MSVC)
> 2. Improve OPT_SET_PTR to prevent same errors in future
> 3. Purge OPT_SET_PTR away since nobody uses it
>
> *Optional* patch №3 is separated from №1 and №2 so that if someone someday
> decides to return OPT_SET_PTR back by reverting №3, it will be returned
> in a sane state.
>
> Decision of (not) merging №3 is left as an exercise to the reader due to
> my insufficient knowledge of accepted practices in Git project.

SET_PTR() may not be used, but are there places where SET_INT() is abused with a cast-to-pointer for the same effect? I didn't check, but if there are such places, converting them to use SET_PTR() with their existing cast removed may be a better way to go.

My suspicion is that there would be none, as switching the behaviour based on a small integer flag value is far easier than swapping the pointer to a pointee to be operated on, when responding to a command line option.

Previous: Marat RadchenkoNext: Jeff King
Message 15 of 17 in “MSVC: fix t0040-parse-options”
  1. MSVC: fix t0040-parse-optionsMarat Radchenko, Mar 28, 2014
  2. Junio C HamanoMar 28, 2014
  3. MSVC: fix t0040-parse-options crashMarat Radchenko, Mar 29, 2014
  4. MSVC: fix t0040-parse-options crashMarat Radchenko, Mar 29, 2014
  5. Andreas SchwabMar 29, 2014
  6. René ScharfeMar 29, 2014
  7. Junio C HamanoMar 30, 2014
  8. Andreas SchwabMar 30, 2014
  9. Jeff KingMar 31, 2014
  10. 0/3 Take four on fixing OPT_SET_PTR issuesMarat Radchenko, Mar 30, 2014
  11. 1/3 MSVC: fix t0040-parse-options crashMarat Radchenko, Mar 30, 2014
  12. 2/3 parse-options: add cast to correct pointer type to OPT_SET_PTRMarat Radchenko, Mar 30, 2014
  13. Junio C HamanoMar 31, 2014
  14. 3/3 parse-options: remove unused OPT_SET_PTRMarat Radchenko, Mar 30, 2014
  15. Junio C HamanoMar 31, 2014
  16. Jeff KingMar 31, 2014
  17. Junio C HamanoMar 31, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.