Re: [PATCH v3] MSVC: fix t0040-parse-options crash

From: René Scharfe <l.s.r@web.de>
Date: Mar 29, 2014, 22:17 UTC
Message-ID: <53374667.3080605@web.de>
In-Reply-To: <87ha6gpu2t.fsf@igel.home>

Am 29.03.2014 22:34, schrieb Andreas Schwab:

Show 14 quoted lines

> Marat Radchenko <marat@slonopotamus.org> writes:
>
>> diff --git a/test-parse-options.c b/test-parse-options.c
>> index 434e8b8..6f6c656 100644
>> --- a/test-parse-options.c
>> +++ b/test-parse-options.c
>> @@ -60,7 +60,7 @@ int main(int argc, char **argv)
>>   		OPT_STRING('o', NULL, &string, "str", "get another string"),
>>   		OPT_NOOP_NOARG(0, "obsolete"),
>>   		OPT_SET_PTR(0, "default-string", &string,
>> -			"set string to default", (unsigned long)"default"),
>> +			"set string to default", (intptr_t)"default"),
>
> Why doesn't OPT_SET_PTR take a pointer?

Good question. Here's another: OPT_SET_PTR (and OPTION_SET_PTR) has only ever been used by test-parse-options; can we remove it?

René