git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] MSVC: fix t0040-parse-options crash

From
Andreas Schwab <schwab@linux-m68k.org>
Date
Mar 29, 2014, 21:34 UTC
Message-ID
<87ha6gpu2t.fsf@igel.home>
In-Reply-To
<1396123762-28673-1-git-send-email-marat@slonopotamus.org>
Marat Radchenko <marat@slonopotamus.org> writes:
Show 10 quoted lines
> diff --git a/test-parse-options.c b/test-parse-options.c
> index 434e8b8..6f6c656 100644
> --- a/test-parse-options.c
> +++ b/test-parse-options.c
> @@ -60,7 +60,7 @@ int main(int argc, char **argv)
>  		OPT_STRING('o', NULL, &string, "str", "get another string"),
>  		OPT_NOOP_NOARG(0, "obsolete"),
>  		OPT_SET_PTR(0, "default-string", &string,
> -			"set string to default", (unsigned long)"default"),
> +			"set string to default", (intptr_t)"default"),
Why doesn't OPT_SET_PTR take a pointer?
Andreas.
-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
Previous: Marat RadchenkoNext: René Scharfe
Message 5 of 17 in “MSVC: fix t0040-parse-options”
  1. MSVC: fix t0040-parse-optionsMarat Radchenko, Mar 28, 2014
  2. Junio C HamanoMar 28, 2014
  3. MSVC: fix t0040-parse-options crashMarat Radchenko, Mar 29, 2014
  4. MSVC: fix t0040-parse-options crashMarat Radchenko, Mar 29, 2014
  5. Andreas SchwabMar 29, 2014
  6. René ScharfeMar 29, 2014
  7. Junio C HamanoMar 30, 2014
  8. Andreas SchwabMar 30, 2014
  9. Jeff KingMar 31, 2014
  10. 0/3 Take four on fixing OPT_SET_PTR issuesMarat Radchenko, Mar 30, 2014
  11. 1/3 MSVC: fix t0040-parse-options crashMarat Radchenko, Mar 30, 2014
  12. 2/3 parse-options: add cast to correct pointer type to OPT_SET_PTRMarat Radchenko, Mar 30, 2014
  13. Junio C HamanoMar 31, 2014
  14. 3/3 parse-options: remove unused OPT_SET_PTRMarat Radchenko, Mar 30, 2014
  15. Junio C HamanoMar 31, 2014
  16. Jeff KingMar 31, 2014
  17. Junio C HamanoMar 31, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.