[PATCH v2] MSVC: fix t0040-parse-options crash
- From
Marat Radchenko <marat@slonopotamus.org>
- Date
- Mar 29, 2014, 19:59 UTC
- Message-ID
- <1396123198-26402-1-git-send-email-marat@slonopotamus.org>
- In-Reply-To
- <xmqq7g7eb2zv.fsf@gitster.dls.corp.google.com>
On 64-bit MSVC, pointers are 64 bit but `long` is only 32. Thus, casting string to `unsigned long`, which is redundand on other platforms, throws away important bits and when later cast to `intptr_t` results in corrupt pointer.
This patch fixes test-parse-options by simply removing harming cast.
Signed-off-by: Marat Radchenko <marat@slonopotamus.org> ---
I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages. I will write verbose commit messages.
Junio, thank you for your patience.
test-parse-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test-parse-options.c b/test-parse-options.c index 434e8b8..10da63e 100644 --- a/test-parse-options.c +++ b/test-parse-options.c @@ -60,7 +60,7 @@ int main(int argc, char **argv) OPT_STRING('o', NULL, &string, "str", "get another string"), OPT_NOOP_NOARG(0, "obsolete"), OPT_SET_PTR(0, "default-string", &string, - "set string to default", (unsigned long)"default"), + "set string to default", "default"), OPT_STRING_LIST(0, "list", &list, "str", "add str to list"), OPT_GROUP("Magic arguments"), OPT_ARGUMENT("quux", "means --quux"),
-- 1.9.0