Re: preview: What's cooking in git.git (Jun 2016, #10; Tue, 28)

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 29, 2016, 16:57 UTC
Message-ID: <xmqq4m8c53wk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1606291345440.12947@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 24 quoted lines

> On Tue, 28 Jun 2016, Junio C Hamano wrote:
>
>> * jk/ansi-color (2016-06-23) 7 commits
>>   (merged to 'next' on 2016-06-28 at 354989c)
>>  + color: support strike-through attribute
>>  + color: support "italic" attribute
>>  + color: allow "no-" for negating attributes
>>  + color: refactor parse_attr
>>  + add skip_prefix_mem helper
>>  + doc: refactor description of color format
>>  + color: fix max-size comment
>> 
>>  The output coloring scheme learned two new attributes, italic and
>>  strike, in addition to existing bold, reverse, etc.
>> 
>>  Will merge to 'master'.
>
> Please note that those "colors" do not work on Windows, at least as far as
> I know, I only skimmed the code in set_attr():
>
> 	https://github.com/git/git/blob/v2.9.0/compat/winansi.c#L175-L314
>
> ... and it looks as if italic is plainly unsupported, and strike-through
> is not handled.

This hopefully is a low-hanging-fruit for aspiring new developers in the Windows land, perhaps?

We do not use italic/strike as a built-in default style for anything, so we do not have to wait for Windows support of these two attributes to appear to include this topic in the next release.

After all, users on "screen", or anything that translates these ANSI colors via termcap/terminfo, do not get them, either. A user may try using these once, notices that her terminal lacks support, and would move on.

Thanks.