Re: preview: What's cooking in git.git (Jun 2016, #10; Tue, 28)

From: Jeff King <peff@peff.net>
Date: Jun 30, 2016, 06:26 UTC
Message-ID: <20160630062638.GB15380@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.2.20.1606291345440.12947@virtualbox>

On Wed, Jun 29, 2016 at 01:47:31PM +0200, Johannes Schindelin wrote:

Show 24 quoted lines

> On Tue, 28 Jun 2016, Junio C Hamano wrote:
> 
> > * jk/ansi-color (2016-06-23) 7 commits
> >   (merged to 'next' on 2016-06-28 at 354989c)
> >  + color: support strike-through attribute
> >  + color: support "italic" attribute
> >  + color: allow "no-" for negating attributes
> >  + color: refactor parse_attr
> >  + add skip_prefix_mem helper
> >  + doc: refactor description of color format
> >  + color: fix max-size comment
> > 
> >  The output coloring scheme learned two new attributes, italic and
> >  strike, in addition to existing bold, reverse, etc.
> > 
> >  Will merge to 'master'.
> 
> Please note that those "colors" do not work on Windows, at least as far as
> I know, I only skimmed the code in set_attr():
> 
> 	https://github.com/git/git/blob/v2.9.0/compat/winansi.c#L175-L314
> 
> ... and it looks as if italic is plainly unsupported, and strike-through
> is not handled.

I suspect winansi doesn't handle 256-color or 24-bit color modes either, and those are also not supported on all terminals. All of the color output is subject to the user's terminal supporting it. It might be that we should make a more clear disclaimer in the documentation.

-Peff