Re: preview: What's cooking in git.git (Jun 2016, #10; Tue, 28)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 29, 2016, 11:47 UTC
Message-ID: <alpine.DEB.2.20.1606291345440.12947@virtualbox>
In-Reply-To: <xmqq4m8c7uo6.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Tue, 28 Jun 2016, Junio C Hamano wrote:

Show 14 quoted lines

> * jk/ansi-color (2016-06-23) 7 commits
>   (merged to 'next' on 2016-06-28 at 354989c)
>  + color: support strike-through attribute
>  + color: support "italic" attribute
>  + color: allow "no-" for negating attributes
>  + color: refactor parse_attr
>  + add skip_prefix_mem helper
>  + doc: refactor description of color format
>  + color: fix max-size comment
> 
>  The output coloring scheme learned two new attributes, italic and
>  strike, in addition to existing bold, reverse, etc.
> 
>  Will merge to 'master'.

Please note that those "colors" do not work on Windows, at least as far as I know, I only skimmed the code in set_attr():

	https://github.com/git/git/blob/v2.9.0/compat/winansi.c#L175-L314

... and it looks as if italic is plainly unsupported, and strike-through is not handled.

Ciao, Dscho