Re: preview: What's cooking in git.git (Jun 2016, #10; Tue, 28)

From: Jeff King <peff@peff.net>
Date: Jun 29, 2016, 01:43 UTC
Message-ID: <20160629014342.GA28661@sigill.intra.peff.net>
In-Reply-To: <xmqq4m8c7uo6.fsf@gitster.mtv.corp.google.com>

On Tue, Jun 28, 2016 at 04:36:25PM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> * jk/test-match-signal (2016-06-24) 4 commits
>  - t/lib-git-daemon: use test_match_signal
>  - test_must_fail: use test_match_signal
>  - t0005: use test_match_signal as appropriate
>  - tests: factor portable signal check out of t0005
> 
>  The test framework learned a new helper test_match_signal to check
>  an exit code from getting killed by an expected signal.
> 
>  Will merge to 'next'.

Johannes pointed out that matching "3" for Windows is overly broad (it only happens due to raise(), not regular signal death).

What do we want to do there?

I _think_ matching "3" just makes us slightly less careful, and will not cause false positives (it may cause false negatives in very specific cases, though). So one option is to proceed as-is.

Another is to just put the posix/ksh schemes into the helper function, and let Windows people sort it out later if they want to.

-Peff