Re: [PATCH] Completion: Add support for --submodule=diff

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 30, 2017, 23:03 UTC
Message-ID: <xmqq4m0gtakk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAKoneT+Bn+MdbeNnPJsu23rbLCZ=jxADNVtpNefw9zNYMq26dA@mail.gmail.com>

Peter Law <peterjclaw@gmail.com> writes:

Show 7 quoted lines

>> Teach git-completion.bash about the 'diff' option to 'git diff
>> --submodule=', which was added in Git 2.11.
>
> I posted this patch back in December, but I've not heard anything. I'm
> sure as maintainers you're all quite busy, but I was wondering how
> long it usually takes to get a response to patches? (also whether I'd
> gotten some part of the submission process wrong?)

When there is clear "subsystem maintainer(s)" in the area, I try to refrain from commenting until they speak up, and completion scripts are one of these areas. I usually ping them after a few days but in December with holidays and things people are usually slow, and so was I X-<.

Will pick it up. Thanks for a reminder; you absolutely did the right thing (i.e. sending it out with people who are likely to know about the area CC'ed, waiting for a while and then sending a reminder).