git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Completion: Add support for --submodule=diff

From
BWBrandon Williams <bmwill@google.com>
Date
Jan 30, 2017, 21:43 UTC
Message-ID
<20170130214312.GB35626@google.com>
In-Reply-To
<CAKoneT+Bn+MdbeNnPJsu23rbLCZ=jxADNVtpNefw9zNYMq26dA@mail.gmail.com>
On 01/30, Peter Law wrote:
Show 12 quoted lines
> Hi,
> 
> > Teach git-completion.bash about the 'diff' option to 'git diff
> > --submodule=', which was added in Git 2.11.
> 
> I posted this patch back in December, but I've not heard anything. I'm
> sure as maintainers you're all quite busy, but I was wondering how
> long it usually takes to get a response to patches? (also whether I'd
> gotten some part of the submission process wrong?)
> 
> Thanks,
> Peter

It looks like this must have just fallen through the cracks. Your patch looks good to me and works when I test it locally.

-- 
Brandon Williams
Previous: Peter LawNext: Junio C Hamano
Message 3 of 6 in “Completion: Add support for --submodule=diff”
  1. Completion: Add support for --submodule=diffpeterjclaw@gmail.com, Dec 4, 2016
  2. Peter LawJan 30, 2017
  3. Brandon WilliamsJan 30, 2017
  4. Junio C HamanoJan 30, 2017
  5. Peter LawFeb 6, 2017
  6. Jacob KellerJan 31, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.