Re: [PATCH] Completion: Add support for --submodule=diff

From: Jacob Keller <jacob.keller@gmail.com>
Date: Jan 31, 2017, 00:10 UTC
Message-ID: <CA+P7+xqYGigV=8k_vS+4Y5fS2ORHUjYOnNRsAGYb1BwCx13xzg@mail.gmail.com>
In-Reply-To: <20161204144127.28452-1-peterjclaw@gmail.com>

On Sun, Dec 4, 2016 at 6:41 AM,  <peterjclaw@gmail.com> wrote:

Show 26 quoted lines

> From: Peter Law <PeterJCLaw@gmail.com>
>
> Teach git-completion.bash about the 'diff' option to 'git diff
> --submodule=', which was added in Git 2.11.
>
> Signed-off-by: Peter Law <PeterJCLaw@gmail.com>
> ---
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 21016bf8d..ab11e7371 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1206,7 +1206,7 @@ _git_describe ()
>
>  __git_diff_algorithms="myers minimal patience histogram"
>
> -__git_diff_submodule_formats="log short"
> +__git_diff_submodule_formats="diff log short"
>
>  __git_diff_common_options="--stat --numstat --shortstat --summary
>                         --patch-with-stat --name-only --name-status --color
> --
> 2.11.0
>

Yep, this looks good to me.

Thanks, Jake