git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Completion: Add support for --submodule=diff

From
Peter Law <peterjclaw@gmail.com>
Date
Feb 6, 2017, 22:56 UTC
Message-ID
<CAKoneTL3-1ohv22mm-RpZ-2sNbFeAV62wOS-JoE0r2Dcn_2E3A@mail.gmail.com>
In-Reply-To
<xmqq4m0gtakk.fsf@gitster.mtv.corp.google.com>
Hi,
Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
> Peter Law <peterjclaw@gmail.com> writes:
>
>>> Teach git-completion.bash about the 'diff' option to 'git diff
>>> --submodule=', which was added in Git 2.11.
>>
>> I posted this patch back in December, but I've not heard anything. I'm
>> sure as maintainers you're all quite busy, but I was wondering how
>> long it usually takes to get a response to patches? (also whether I'd
>> gotten some part of the submission process wrong?)
>
> When there is clear "subsystem maintainer(s)" in the area, I try to
> refrain from commenting until they speak up, and completion scripts
> are one of these areas.  I usually ping them after a few days but in
> December with holidays and things people are usually slow, and so
> was I X-<.
>
> Will pick it up.  Thanks for a reminder; you absolutely did the
> right thing (i.e. sending it out with people who are likely to know
> about the area CC'ed, waiting for a while and then sending a
> reminder).
Awesome, many thanks!
Peter
Previous: Junio C HamanoNext: Jacob Keller
Message 5 of 6 in “Completion: Add support for --submodule=diff”
  1. Completion: Add support for --submodule=diffpeterjclaw@gmail.com, Dec 4, 2016
  2. Peter LawJan 30, 2017
  3. Brandon WilliamsJan 30, 2017
  4. Junio C HamanoJan 30, 2017
  5. Peter LawFeb 6, 2017
  6. Jacob KellerJan 31, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.