Re: What's cooking in git.git (Apr 2018, #01; Mon, 9)

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 9, 2018, 22:08 UTC
Message-ID: <xmqq4lkk58y0.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <bba6e3ba-ab28-8cda-eab3-91ec3591bcb5@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 31 quoted lines

> On 09/04/18 14:37, Derrick Stolee wrote:
>> On 4/9/2018 6:21 AM, Junio C Hamano wrote:
>>> * ds/commit-graph (2018-04-02) 16 commits
>>>   - commit-graph: implement "--additive" option
>>> ...
>>>   Ready???
>>>   It seems that this topic is getting there.
>> 
>> I think this patch is ready to go, barring ...
>
> Also, it seems that the 'static' keyword has been dropped from the
> declaration of 'commit_graph' (commit-graph.c #183) again:
>
>   $ diff nsp-out psp-out
>   18a19
>   >     SP chdir-notify.c
>   23a25,26
>   >     SP commit-graph.c
>   > commit-graph.c:183:21: warning: symbol 'commit_graph' was not declared. Should it be static?
>   66a70
>   >     SP json-writer.c
>   209a214,215
>   >     SP builtin/commit-graph.c
>   > builtin/commit-graph.c:34:38: warning: Using plain integer as NULL pointer
>   299d304
>   < fast-import.c:303:40: warning: Using plain integer as NULL pointer
>   312a318
>   >     SP t/helper/test-json-writer.c
>   315a322
>   >     SP t/helper/test-print-larger-than-ssize.c
>   $

I guess we'd want a final cleaned-up round after all ;-)  Thanks.