git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Apr 2018, #01; Mon, 9)

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Apr 10, 2018, 20:37 UTC
Message-ID
<ebb92e9f-161e-5727-89be-052dfd6e853e@ramsayjones.plus.com>
In-Reply-To
<400756e6-b8df-168e-55b6-652e1f9298be@ramsayjones.plus.com>
On 10/04/18 21:22, Ramsay Jones wrote:
Show 52 quoted lines
> 
> 
> On 10/04/18 20:35, Derrick Stolee wrote:
>> On 4/10/2018 3:21 PM, Ramsay Jones wrote:
>>>
>>> On 10/04/18 13:57, Derrick Stolee wrote:
>>>> On 4/9/2018 6:08 PM, Junio C Hamano wrote:
>>>>> I guess we'd want a final cleaned-up round after all ;-)  Thanks.
>>>> v8 sent [1]. Thanks.
>>> I just tried to 'git am' this series and I could not get it
>>> to apply cleanly to current 'master', 'next' or 'pu'. I fixed
>>> up a few patches, but just got bored ... ;-)
>>>
>>
>> In my cover letter, I did mention that my patch started here (using 'format-patch --base'):
>>
>> base-commit: 468165c1d8a442994a825f3684528361727cd8c0
>>
>>
>> This corresponds to v2.17.0.
> 
> Yep, I forgot to mention that I had already tried that too:
> 
> $ git log --oneline -1
> 468165c1d (HEAD -> master-graph, tag: v2.17.0, origin/maint, maint, build) Git 2.17
> $ git am patches/*
> Applying: csum-file: rename hashclose() to finalize_hashfile()
> Applying: csum-file: refactor finalize_hashfile() method
> Applying: commit-graph: add format document
> Applying: graph: add commit graph design document
> Applying: commit-graph: create git-commit-graph builtin
> Applying: commit-graph: create git-commit-graph builtin
> error: patch failed: .gitignore:34
> error: .gitignore: patch does not apply
> error: Documentation/git-commit-graph.txt: already exists in index
> error: patch failed: Makefile:952
> error: Makefile: patch does not apply
> error: patch failed: builtin.h:149
> error: builtin.h: patch does not apply
> error: builtin/commit-graph.c: already exists in index
> error: patch failed: command-list.txt:34
> error: command-list.txt: patch does not apply
> error: patch failed: contrib/completion/git-completion.bash:878
> error: contrib/completion/git-completion.bash: patch does not apply
> error: patch failed: git.c:388
> error: git.c: patch does not apply
> Patch failed at 0006 commit-graph: create git-commit-graph builtin
> Use 'git am --show-current-patch' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> $ 

Ah, OK, it helps if you don't have an edited patch backup file in the patches directory! patches now apply cleanly.

sparse is also now clean - thanks!

ATB, Ramsay Jones

Previous: Ramsay JonesNext: Junio C Hamano
Message 10 of 23 in “What's cooking in git.git (Apr 2018, #01; Mon, 9)”
  1. Junio C HamanoApr 9, 2018
  2. Derrick StoleeApr 9, 2018
  3. Ramsay JonesApr 9, 2018
  4. Junio C HamanoApr 9, 2018
  5. Derrick StoleeApr 10, 2018
  6. Stefan BellerApr 10, 2018
  7. Ramsay JonesApr 10, 2018
  8. Derrick StoleeApr 10, 2018
  9. Ramsay JonesApr 10, 2018
  10. Ramsay JonesApr 10, 2018
  11. Junio C HamanoApr 10, 2018
  12. Duy NguyenApr 9, 2018
  13. Stefan BellerApr 9, 2018
  14. Johannes SchindelinApr 9, 2018
  15. Johannes SchindelinApr 9, 2018
  16. Johannes SchindelinApr 10, 2018
  17. git-gui branches, was Re: What's cooking in git.git (Apr 2018, #01; Mon, 9)Johannes Schindelin, Apr 10, 2018
  18. Junio C HamanoApr 10, 2018
  19. Stefan BellerApr 10, 2018
  20. Johannes SchindelinApr 10, 2018
  21. Phillip WoodApr 11, 2018
  22. Jakub NarebskiApr 11, 2018
  23. Ævar Arnfjörð BjarmasonApr 11, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.