Re: git-gui branches, was Re: What's cooking in git.git (Apr 2018, #01; Mon, 9)

From: Stefan Beller <sbeller@google.com>
Date: Apr 10, 2018, 21:54 UTC
Message-ID: <CAGZ79kb4ny9LNbbYe53WO9eqTAmjUSprUeX9-rhvAehVR_cPgg@mail.gmail.com>
In-Reply-To: <xmqqtvsi214p.fsf@gitster-ct.c.googlers.com>

On Tue, Apr 10, 2018 at 2:38 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>> On Mon, 9 Apr 2018, Junio C Hamano wrote:
>>
>>> * bb/git-gui-ssh-key-files (2018-03-02) 2 commits

This looks good to me. Please merge down.

>>> * bp/git-gui-bind-kp-enter (2018-03-02) 2 commits

I tested and reviewed this, and it also looks good to me.

>>> * cb/git-gui-ttk-style (2018-03-05) 2 commits

While this looks like it doesn't break anything, and it does what it intends to do, I am not sure if that is the best approach. I'll look into Tcl and experiment to have an opinion.

Show 6 quoted lines

>> What is your plan with those? I thought they were on track for v2.17.0,
>> but now I see that they are not even in `next`...
>
> There is no plan. I was waiting for somebody to raise noises, get
> irritated by lack of active subsystem maintainer(s), which would
> eventually lead us to find a replacement for Pat.

Ok, glad that Johannes made noise then. I am a heavy user of git-gui myself so I would feel sad if it wasn't properly maintained. (On the other hand it "just works" -- for me) I'd be ok to step up as a maintainer there in the long run if nobody else steps up.

> I can play patch-monkey for git-gui part but I do not want to be the
> one who judges if proposed changes to it are good ones.  Have they
> been reviewed by git-gui competent people?

For now please apply (or monkey-patch as you put it) the first and second.

Thanks, Stefan