Re: git-gui branches, was Re: What's cooking in git.git (Apr 2018, #01; Mon, 9)
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 10, 2018, 22:41 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1804110040240.56@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
- In-Reply-To
- <xmqqtvsi214p.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Wed, 11 Apr 2018, Junio C Hamano wrote:
Show 18 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > On Mon, 9 Apr 2018, Junio C Hamano wrote: > > > >> * bb/git-gui-ssh-key-files (2018-03-02) 2 commits > >> * bp/git-gui-bind-kp-enter (2018-03-02) 2 commits > >> * cb/git-gui-ttk-style (2018-03-05) 2 commits > > > > What is your plan with those? I thought they were on track for v2.17.0, > > but now I see that they are not even in `next`... > > There is no plan. I was waiting for somebody to raise noises, get > irritated by lack of active subsystem maintainer(s), which would > eventually lead us to find a replacement for Pat. > > I can play patch-monkey for git-gui part but I do not want to be the > one who judges if proposed changes to it are good ones. Have they > been reviewed by git-gui competent people?
I would call myself "reasonably literate" in Tcl/Tk, not "git-gui competent", but for what it is worth: I remember having reviewed those patches and AFAIR they looked fine enough for inclusion. Certainly the ssk-key-files one.
Ciao, Dscho