Re: [RFC PATCH 7/7] config.mak.uname: use pkgsrc perl for NetBSD

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 26, 2018, 06:53 UTC
Message-ID: <xmqq4lc4xrca.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <f7a41204f9c70e3c659877412719f17dc9805589.1543143503.git.carenas@gmail.com>

Carlo Marcelo Arenas Belón  <carenas@gmail.com> writes:

Show 6 quoted lines

> otherwise will default to /usr/bin/perl which wouldn't normally exist
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
>  config.mak.uname | 1 +
>  1 file changed, 1 insertion(+)

I do not have experience with NetBSD so I take your words on face value. This patch makes sense to me.

Thanks.

Show 12 quoted lines

> diff --git a/config.mak.uname b/config.mak.uname
> index 59ce03819b..d2edb723f4 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -249,6 +249,7 @@ ifeq ($(uname_S),NetBSD)
>  	OLD_ICONV = UnfortunatelyYes
>  	BASIC_CFLAGS += -I/usr/pkg/include
>  	BASIC_LDFLAGS += -L/usr/pkg/lib $(CC_LD_DYNPATH)/usr/pkg/lib
> +	PERL_PATH = /usr/pkg/bin/perl
>  	USE_ST_TIMESPEC = YesPlease
>  	HAVE_PATHS_H = YesPlease
>  	HAVE_BSD_SYSCTL = YesPlease