git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 6/7] t5004: use GNU tar to avoid known issues with BSD tar

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Nov 25, 2018, 11:06 UTC
Message-ID
<48f223add200dfcf02f280fcc577cc94255820ce.1543143503.git.carenas@gmail.com>
In-Reply-To
<cover.1543143503.git.carenas@gmail.com>

56ee96572a ("t5004: resurrect original empty tar archive test", 2013-05-09) added a test to try to detect and workaround issues with the standard tar from BSD, but at least in NetBSD would be better to instead require GNU tar which is available from pkgsrc

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 t/t5004-archive-corner-cases.sh | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/t/t5004-archive-corner-cases.sh b/t/t5004-archive-corner-cases.sh
index ced44355ca..baafc553f8 100755
--- a/t/t5004-archive-corner-cases.sh
+++ b/t/t5004-archive-corner-cases.sh
@@ -31,6 +31,8 @@ test_lazy_prereq UNZIP_ZIP64_SUPPORT '
 	"$GIT_UNZIP" -v | grep ZIP64_SUPPORT
 '
 
+test $uname_s = NetBSD && TAR="gtar"
+
 # bsdtar/libarchive versions before 3.1.3 consider a tar file with a
 # global pax header that is not followed by a file record as corrupt.
 if "$TAR" tf "$TEST_DIRECTORY"/t5004/empty-with-pax-header.tar >/dev/null 2>&1
-- 
2.20.0.rc1
Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 16 in “test: NetBSD support”
  1. 0/7 test: NetBSD supportCarlo Marcelo Arenas Belón, Nov 25, 2018
  2. 1/7 Documentation: update INSTALL for NetBSDCarlo Marcelo Arenas Belón, Nov 25, 2018
  3. Junio C HamanoNov 26, 2018
  4. 2/7 t0301: remove trailing / for dir creationCarlo Marcelo Arenas Belón, Nov 25, 2018
  5. Junio C HamanoNov 26, 2018
  6. 3/7 config.mak.uname: NetBSD uses BSD semantics with fread for directoriesCarlo Marcelo Arenas Belón, Nov 25, 2018
  7. Junio C HamanoNov 26, 2018
  8. 4/7 config.mak.uname: NetBSD uses old iconv interfaceCarlo Marcelo Arenas Belón, Nov 25, 2018
  9. Junio C HamanoNov 26, 2018
  10. 5/7 test-lib: use pkgsrc provided unzip for NetBSDCarlo Marcelo Arenas Belón, Nov 25, 2018
  11. Junio C HamanoNov 26, 2018
  12. 6/7 t5004: use GNU tar to avoid known issues with BSD tarCarlo Marcelo Arenas Belón, Nov 25, 2018
  13. Junio C HamanoNov 26, 2018
  14. 7/7 config.mak.uname: use pkgsrc perl for NetBSDCarlo Marcelo Arenas Belón, Nov 25, 2018
  15. Junio C HamanoNov 26, 2018
  16. Ævar Arnfjörð BjarmasonNov 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.