git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 4/7] config.mak.uname: NetBSD uses old iconv interface

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Nov 25, 2018, 11:06 UTC
Message-ID
<5841455b55d7e14f962659ce3bf36c1f04162268.1543143503.git.carenas@gmail.com>
In-Reply-To
<cover.1543143503.git.carenas@gmail.com>
prevents the following warning :
utf8.c: In function 'reencode_string_iconv':
utf8.c:486:28: warning: passing argument 2 of 'iconv' from incompatible pointer type [-Wincompatible-pointer-types]
   size_t cnt = iconv(conv, &cp, &insz, &outpos, &outsz);
                            ^
In file included from git-compat-util.h:275:0,
                 from utf8.c:1:
/usr/include/iconv.h:46:8: note: expected 'const char ** restrict' but argument is of type 'char **'
 size_t iconv(iconv_t, const char ** __restrict,
        ^
it is set by optional configure at least since NetBSD 6.0
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 config.mak.uname | 1 +
 1 file changed, 1 insertion(+)
diff --git a/config.mak.uname b/config.mak.uname
index 36c973c7e6..59ce03819b 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -246,6 +246,7 @@ ifeq ($(uname_S),NetBSD)
 	ifeq ($(shell expr "$(uname_R)" : '[01]\.'),2)
 		NEEDS_LIBICONV = YesPlease
 	endif
+	OLD_ICONV = UnfortunatelyYes
 	BASIC_CFLAGS += -I/usr/pkg/include
 	BASIC_LDFLAGS += -L/usr/pkg/lib $(CC_LD_DYNPATH)/usr/pkg/lib
 	USE_ST_TIMESPEC = YesPlease
-- 
2.20.0.rc1
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 16 in “test: NetBSD support”
  1. 0/7 test: NetBSD supportCarlo Marcelo Arenas Belón, Nov 25, 2018
  2. 1/7 Documentation: update INSTALL for NetBSDCarlo Marcelo Arenas Belón, Nov 25, 2018
  3. Junio C HamanoNov 26, 2018
  4. 2/7 t0301: remove trailing / for dir creationCarlo Marcelo Arenas Belón, Nov 25, 2018
  5. Junio C HamanoNov 26, 2018
  6. 3/7 config.mak.uname: NetBSD uses BSD semantics with fread for directoriesCarlo Marcelo Arenas Belón, Nov 25, 2018
  7. Junio C HamanoNov 26, 2018
  8. 4/7 config.mak.uname: NetBSD uses old iconv interfaceCarlo Marcelo Arenas Belón, Nov 25, 2018
  9. Junio C HamanoNov 26, 2018
  10. 5/7 test-lib: use pkgsrc provided unzip for NetBSDCarlo Marcelo Arenas Belón, Nov 25, 2018
  11. Junio C HamanoNov 26, 2018
  12. 6/7 t5004: use GNU tar to avoid known issues with BSD tarCarlo Marcelo Arenas Belón, Nov 25, 2018
  13. Junio C HamanoNov 26, 2018
  14. 7/7 config.mak.uname: use pkgsrc perl for NetBSDCarlo Marcelo Arenas Belón, Nov 25, 2018
  15. Junio C HamanoNov 26, 2018
  16. Ævar Arnfjörð BjarmasonNov 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.