git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 5/7] test-lib: use pkgsrc provided unzip for NetBSD

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Nov 25, 2018, 11:06 UTC
Message-ID
<5fe64afa3d7cf9a46a527c47885e8e60dae2445c.1543143503.git.carenas@gmail.com>
In-Reply-To
<cover.1543143503.git.carenas@gmail.com>

d98b2c5fce ("test-lib: on FreeBSD, look for unzip(1) in /usr/local/bin/", 2016-07-21) added an exception to the test suite for FreeBSD because the tests assume functionality not provided by its base unzip tool.

NetBSD shares that limitation and provides a package that could be used instead so all tests from t5003 succeed

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 t/test-lib.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 6c6c0af7a1..2acb35f277 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -1244,6 +1244,7 @@ test_lazy_prereq SANITY '
 '
 
 test FreeBSD != $uname_s || GIT_UNZIP=${GIT_UNZIP:-/usr/local/bin/unzip}
+test $uname_s = NetBSD && GIT_UNZIP=${GIT_UNZIP:-/usr/pkg/bin/unzip}
 GIT_UNZIP=${GIT_UNZIP:-unzip}
 test_lazy_prereq UNZIP '
 	"$GIT_UNZIP" -v
-- 
2.20.0.rc1
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 16 in “test: NetBSD support”
  1. 0/7 test: NetBSD supportCarlo Marcelo Arenas Belón, Nov 25, 2018
  2. 1/7 Documentation: update INSTALL for NetBSDCarlo Marcelo Arenas Belón, Nov 25, 2018
  3. Junio C HamanoNov 26, 2018
  4. 2/7 t0301: remove trailing / for dir creationCarlo Marcelo Arenas Belón, Nov 25, 2018
  5. Junio C HamanoNov 26, 2018
  6. 3/7 config.mak.uname: NetBSD uses BSD semantics with fread for directoriesCarlo Marcelo Arenas Belón, Nov 25, 2018
  7. Junio C HamanoNov 26, 2018
  8. 4/7 config.mak.uname: NetBSD uses old iconv interfaceCarlo Marcelo Arenas Belón, Nov 25, 2018
  9. Junio C HamanoNov 26, 2018
  10. 5/7 test-lib: use pkgsrc provided unzip for NetBSDCarlo Marcelo Arenas Belón, Nov 25, 2018
  11. Junio C HamanoNov 26, 2018
  12. 6/7 t5004: use GNU tar to avoid known issues with BSD tarCarlo Marcelo Arenas Belón, Nov 25, 2018
  13. Junio C HamanoNov 26, 2018
  14. 7/7 config.mak.uname: use pkgsrc perl for NetBSDCarlo Marcelo Arenas Belón, Nov 25, 2018
  15. Junio C HamanoNov 26, 2018
  16. Ævar Arnfjörð BjarmasonNov 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.