Re: [PATCH 2/4] kwset: allow building with GCC 8

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 14, 2019, 16:12 UTC
Message-ID: <xmqq4l4suovx.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190614095308.GG31952@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 5 quoted lines

>> Now, the proper thing to do would be to switch to `size_t`. But this
>> would make us deviate from the "upstream" code even further,
>
> This is not entirely true: upstream already uses 'size_t', so the
> switch would actually bring our copy closer to upstream.

Ah, earlier I said that within the context how kwset uses obstack, it is perfectly proper to fix it like the patch in question did, but the upstream already using size_t changes the picture quite a bit.

I do not mind updating our copy of obstack, but make sure you pick the version with license compatible with ours.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.