From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Jun 2019 16:12:50 GMT
Subject: Re: [PATCH 2/4] kwset: allow building with GCC 8
Message-ID: <xmqq4l4suovx.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190614095308.GG31952@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

>> Now, the proper thing to do would be to switch to `size_t`. But this
>> would make us deviate from the "upstream" code even further,
>
> This is not entirely true: upstream already uses 'size_t', so the
> switch would actually bring our copy closer to upstream.

Ah, earlier I said that within the context how kwset uses obstack,
it is perfectly proper to fix it like the patch in question did, but
the upstream already using size_t changes the picture quite a bit.

I do not mind updating our copy of obstack, but make sure you pick
the version with license compatible with ours.

Thanks.