Re: [PATCH v3 08/12] bundle: parse filter capability

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 8, 2022, 17:29 UTC
Message-ID: <xmqq4k48nyjn.fsf@gitster.g>
In-Reply-To: <025f38290f5a705c80854a42e1abcaba9a9f336d.1646750359.git.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 17 quoted lines

> diff --git a/bundle.h b/bundle.h
> index 06009fe6b1f..7fef2108f43 100644
> --- a/bundle.h
> +++ b/bundle.h
> @@ -4,12 +4,14 @@
>  #include "strvec.h"
>  #include "cache.h"
>  #include "string-list.h"
> +#include "list-objects-filter-options.h"
>  
>  struct bundle_header {
>  	unsigned version;
>  	struct string_list prerequisites;
>  	struct string_list references;
>  	const struct git_hash_algo *hash_algo;
> +	struct list_objects_filter_options filter;
>  };

This used to be a pointer to the struct, with "NULL means do not filter" semantics, with .nr==0 as BUG(). Which was the same justification used when an earlier step added a pointer to the filter struct to rev_info.

Should the same logic applies there to make it into an embedded struct in rev_info as well?