Re: [PATCH v2 07/12] bundle: safely handle --objects option

From: Derrick Stolee <derrickstolee@github.com>
Date: Mar 8, 2022, 13:45 UTC
Message-ID: <ea7b6ac0-1212-6682-60cf-d79f5deb61e5@github.com>
In-Reply-To: <220308.86h788ydm6.gmgdl@evledraar.gmail.com>

On 3/8/2022 4:37 AM, Ævar Arnfjörð Bjarmason wrote:

Show 8 quoted lines

> 
> Re this comment on v1: https://lore.kernel.org/git/220307.86fsntzsda.gmgdl@evledraar.gmail.com/
> Aside from whether that's a good idea, doesn't that at least point to
> missing test coverage here, see traverse_non_commits() and other paths
> in list-objects.c that'll call ctx->show_object().
> 
> I think an actually sensible patch for this is the below, i.e. the API
> is conflating "do show" with "should we show AND we have a callback?":

...

> I think that'll do what you want, and also seems to set us up for safer
> API use going forward, i.e. we have a couple of NULL-passing callers
> already.

Squashing this change into the commit makes most sense to attribute authorship to you. May I forge your sign-off in that patch for v3?

Thanks, -Stolee