Re: [PATCH 11/11] bundle: unbundle promisor packs

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 7, 2022, 19:54 UTC
Message-ID: <xmqq35jtsfm9.fsf@gitster.g>
In-Reply-To: <51fabaef-4849-2d9f-285a-3f442f803717@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 7 quoted lines

> I've been trying this:
>
>  git clone --no-local --filter=$filter "file://$(pwd)" cloned &&
>
> which "succeeds" with this in the stderr:
>
>  warning: filtering not recognized by server, ignoring

Hmph, and we won't see it when going over ssh to the same repository? That is puzzling.

Show 10 quoted lines

>>> an error condition into 'git clone' to say "Cannot currently clone
>>> from a filtered bundle" to help users understand the issue?
>> 
>> It would be a workable stepwise solution, I would think.  It is not
>> like we are robbing an existing feature from users---it merely is
>> that the support of partial cloning over different "transport" is
>> uneven, which is to be expected, especially in earlier phase of
>> introducing a new feature.
>
> That was my understanding, too.

Good to see us on the same page.  Thanks.