Re: [PATCH v2] Documentation: add ReviewingGuidelines
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 19, 2022, 21:37 UTC
- Message-ID
- <xmqq4jx39hb6.fsf@gitster.g>
- In-Reply-To
- <pull.1348.v2.git.1663614767058.gitgitgadget@gmail.com>
"Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 20 quoted lines
> From: Victoria Dye <vdye@github.com> > > Add a reviewing guidelines document including advice and common terminology > used in Git mailing list reviews. The document is included in the > 'TECH_DOCS' list in order to include it in Git's published documentation. > > Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de> > Helped-by: Derrick Stolee <derrickstolee@github.com> > Helped-by: Junio C Hamano <gitster@pobox.com> > Helped-by: Josh Steadmon <steadmon@google.com> > Signed-off-by: Victoria Dye <vdye@github.com> > --- > Documentation: add ReviewingGuidelines > > This patch follows up on a discussion a few weeks ago in the Git IRC > standup [1], where it was mentioned that it would be nice to have > consistent definitions for common review terminology (like 'nit:'). The > "ReviewingGuidelines" document created here builds on that idea, as well > as past discussions around the idea of advice for reviewers (similar to > the guidelines for new contributors in MyFirstContribution [2]).
Thanks. Will queue.
I think this is ready for 'next' and then to 'master' during this cycle. Thanks for writing it, and thanks all for reviewing it.