git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation: add ReviewingGuidelines

From
Victoria Dye <vdye@github.com>
Date
Sep 13, 2022, 23:11 UTC
Message-ID
<5685773e-db83-6b92-ff42-0d51e6e6a22e@github.com>
In-Reply-To
<xmqqr10f88jm.fsf@gitster.g>
Junio C Hamano wrote:
Show 15 quoted lines
> "Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Victoria Dye <vdye@github.com>
>>
>> Add a reviewing guidelines document including advice and common terminology
>> used in Git mailing list reviews. The document is included in the
>> 'TECH_DOCS' list in order to include it in Git's published documentation.
>>
>> Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> Helped-by: Derrick Stolee <derrickstolee@github.com>
>> Signed-off-by: Victoria Dye <vdye@github.com>
>> ---
> 
> I've commented on the text but haven't seen anybody else reviewing.
> No interest?  Everybody silently happy?

My guess is that there aren't as many eyes on this as there might typically be because of Git Merge. In any case, I plan to re-roll based on your feedback [1] (ideally) by the end of the week if other reviews aren't sent in the meantime.

I'm hoping there's a bit more interest after Git Merge. With reviewing being such an integral part of contribution to Git, I'm really interested in hearing people's thoughts on what should/shouldn't be in this document.

[1] https://lore.kernel.org/git/xmqqwnacibbm.fsf@gitster.g/
Previous: Junio C HamanoNext: Derrick Stolee
Message 4 of 15 in “Documentation: add ReviewingGuidelines”
  1. Documentation: add ReviewingGuidelinesVictoria Dye via GitGitGadget, Sep 9, 2022
  2. Junio C HamanoSep 9, 2022
  3. Junio C HamanoSep 13, 2022
  4. Victoria DyeSep 13, 2022
  5. Derrick StoleeSep 19, 2022
  6. Johannes SchindelinSep 19, 2022
  7. Josh SteadmonSep 15, 2022
  8. Glen ChooSep 19, 2022
  9. Documentation: add ReviewingGuidelinesVictoria Dye via GitGitGadget, Sep 19, 2022
  10. Josh SteadmonSep 19, 2022
  11. Junio C HamanoSep 19, 2022
  12. Elijah NewrenSep 20, 2022
  13. Konstantin RyabitsevSep 20, 2022
  14. Shaoxuan YuanSep 22, 2022
  15. Phillip WoodSep 22, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.