git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation: add ReviewingGuidelines

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Sep 19, 2022, 15:48 UTC
Message-ID
<ono01655-2r33-9081-q542-p2sp8r5n65s3@tzk.qr>
In-Reply-To
<925b1e37-17aa-9168-9246-ac48e043c0d4@github.com>
Hi,
On Mon, 19 Sep 2022, Derrick Stolee wrote:
Show 32 quoted lines
> On 9/13/2022 7:11 PM, Victoria Dye wrote:
> > Junio C Hamano wrote:
> >> "Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:
> >>
> >>> From: Victoria Dye <vdye@github.com>
> >>>
> >>> Add a reviewing guidelines document including advice and common terminology
> >>> used in Git mailing list reviews. The document is included in the
> >>> 'TECH_DOCS' list in order to include it in Git's published documentation.
> >>>
> >>> Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> >>> Helped-by: Derrick Stolee <derrickstolee@github.com>
> >>> Signed-off-by: Victoria Dye <vdye@github.com>
> >>> ---
> >>
> >> I've commented on the text but haven't seen anybody else reviewing.
> >> No interest?  Everybody silently happy?
> >
> > My guess is that there aren't as many eyes on this as there might typically
> > be because of Git Merge.
>
> Yes, Git Merge took all of my attention in the past week, so I couldn't
> chime in at all here.
>
> My "Helped-by" includes some small suggestions from me, but mostly I
> fully support having this kind of document. This one is an excellent
> base to start from for future augmentation as we discover ideas that
> could avoid sticky situations.
>
> I particularly like how this document assumes good intent from all
> parties, but recommends over-communicating to be sure that intent is
> clear to everyone.
What Stolee said.

I really like how this document serves as a great inspiration to align actions with intentions (answering the question "How do I craft my review in a way that the reader _sees_ my good intention, too?"; Sometimes there is a disconnect between intent and impact).

Thank you for putting this together, Victoria! Dscho

Previous: Derrick StoleeNext: Josh Steadmon
Message 6 of 15 in “Documentation: add ReviewingGuidelines”
  1. Documentation: add ReviewingGuidelinesVictoria Dye via GitGitGadget, Sep 9, 2022
  2. Junio C HamanoSep 9, 2022
  3. Junio C HamanoSep 13, 2022
  4. Victoria DyeSep 13, 2022
  5. Derrick StoleeSep 19, 2022
  6. Johannes SchindelinSep 19, 2022
  7. Josh SteadmonSep 15, 2022
  8. Glen ChooSep 19, 2022
  9. Documentation: add ReviewingGuidelinesVictoria Dye via GitGitGadget, Sep 19, 2022
  10. Josh SteadmonSep 19, 2022
  11. Junio C HamanoSep 19, 2022
  12. Elijah NewrenSep 20, 2022
  13. Konstantin RyabitsevSep 20, 2022
  14. Shaoxuan YuanSep 22, 2022
  15. Phillip WoodSep 22, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.